On 2023-05-21 20:12:00, Marijn Suijten wrote: > On 2023-05-21 20:21:46, Dmitry Baryshkov wrote: > > Drop SSPP-specifig debugfs register dumps in favour of using > > debugfs/dri/0/kms or devcoredump. > > > > Signed-off-by: Dmitry Baryshkov <dmitry.barysh...@linaro.org> > > Reviewed-by: Marijn Suijten <marijn.suij...@somainline.org> > > > --- > > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c | 25 --------------------- > > 1 file changed, 25 deletions(-) > > > > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c > > b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c > > index bfd82c2921af..6c5ebee2f7cd 100644 > > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c > > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c > > @@ -727,31 +727,6 @@ int _dpu_hw_sspp_init_debugfs(struct dpu_hw_sspp > > *hw_pipe, struct dpu_kms *kms, > > debugfs_create_xul("features", 0600, > > debugfs_root, (unsigned long *)&hw_pipe->cap->features); > > > > - /* add register dump support */ > > - dpu_debugfs_create_regset32("src_blk", 0400, > > - debugfs_root, > > - sblk->src_blk.base + cfg->base, > > - sblk->src_blk.len,
Note that this fails to apply on top of https://lore.kernel.org/linux-arm-msm/20230429012353.2569481-2-dmitry.barysh...@linaro.org/ - Marijn > > - kms); > > - > > - if (cfg->features & BIT(DPU_SSPP_SCALER_QSEED3) || > > - cfg->features & BIT(DPU_SSPP_SCALER_QSEED3LITE) || > > - cfg->features & BIT(DPU_SSPP_SCALER_QSEED2) || > > - cfg->features & BIT(DPU_SSPP_SCALER_QSEED4)) > > - dpu_debugfs_create_regset32("scaler_blk", 0400, > > - debugfs_root, > > - sblk->scaler_blk.base + cfg->base, > > - sblk->scaler_blk.len, > > - kms); > > - > > - if (cfg->features & BIT(DPU_SSPP_CSC) || > > - cfg->features & BIT(DPU_SSPP_CSC_10BIT)) > > - dpu_debugfs_create_regset32("csc_blk", 0400, > > - debugfs_root, > > - sblk->csc_blk.base + cfg->base, > > - sblk->csc_blk.len, > > - kms); > > - > > debugfs_create_u32("xin_id", > > 0400, > > debugfs_root, > > -- > > 2.39.2 > >