On Thu, Apr 04, 2024 at 05:01:03PM -0700, Stephen Boyd wrote:
> The register base that was used to write to the QSERDES_DP_PHY_MODE
> register was 'dp_dp_phy' before commit 815891eee668 ("phy:
> qcom-qmp-combo: Introduce orientation variable"). There isn't any
> explanation in the commit why this is changed, so I suspect it was an
> oversight or happened while being extracted from some other series.
Thanks for catching that, I wrote that patch long before Johan did the
rename of "pcs" to "dp_dp_phy", and must have missed that while later
rebasing the patch.
Reviewed-by: Bjorn Andersson <quic_bjora...@quicinc.com>
Regards,
Bjorn
> Oddly the value being 0x4c or 0x5c doesn't seem to matter for me, so I
> suspect this is dead code, but that can be fixed in another patch. It's
> not good to write to the wrong register space, and maybe some other
> version of this phy relies on this.
>
> Cc: Douglas Anderson <diand...@chromium.org>
> Cc: Abhinav Kumar <quic_abhin...@quicinc.com>
> Cc: Dmitry Baryshkov <dmitry.barysh...@linaro.org>
> Cc: Neil Armstrong <neil.armstr...@linaro.org>
> Cc: Abel Vesa <abel.v...@linaro.org>
> Cc: Steev Klimaszewski <st...@kali.org>
> Cc: Johan Hovold <johan+lin...@kernel.org>
> Cc: Bjorn Andersson <quic_bjora...@quicinc.com>
> Fixes: 815891eee668 ("phy: qcom-qmp-combo: Introduce orientation variable")
> Signed-off-by: Stephen Boyd <swb...@chromium.org>
> ---
> drivers/phy/qualcomm/phy-qcom-qmp-combo.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-combo.c
> b/drivers/phy/qualcomm/phy-qcom-qmp-combo.c
> index 7d585a4bbbba..746d009d702b 100644
> --- a/drivers/phy/qualcomm/phy-qcom-qmp-combo.c
> +++ b/drivers/phy/qualcomm/phy-qcom-qmp-combo.c
> @@ -2150,9 +2150,9 @@ static bool qmp_combo_configure_dp_mode(struct
> qmp_combo *qmp)
> writel(val, qmp->dp_dp_phy + QSERDES_DP_PHY_PD_CTL);
>
> if (reverse)
> - writel(0x4c, qmp->pcs + QSERDES_DP_PHY_MODE);
> + writel(0x4c, qmp->dp_dp_phy + QSERDES_DP_PHY_MODE);
> else
> - writel(0x5c, qmp->pcs + QSERDES_DP_PHY_MODE);
> + writel(0x5c, qmp->dp_dp_phy + QSERDES_DP_PHY_MODE);
>
> return reverse;
> }
>
> base-commit: 4cece764965020c22cff7665b18a012006359095
> --
> https://chromeos.dev
>
