The DPU driver isn't expected to be used without an IOMMU. Thus the
aspace will be always present. Not to mention that mdp4/mdp5 drivers
call msm_framebuffer_iova() without such checks, as the whole
msm_framebuffer layer is expected to support both IOMMU and IOMMU-less
configurations.

Drop these useless if (aspace) checks.

Signed-off-by: Dmitry Baryshkov <dmitry.barysh...@linaro.org>
---
 drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c 
b/drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c
index 027eb5ecff08..8c2dc5b59bb0 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c
@@ -280,8 +280,7 @@ static int _dpu_format_populate_addrs_ubwc(
                return -EINVAL;
        }
 
-       if (aspace)
-               base_addr = msm_framebuffer_iova(fb, aspace, 0);
+       base_addr = msm_framebuffer_iova(fb, aspace, 0);
        if (!base_addr) {
                DRM_ERROR("failed to retrieve base addr\n");
                return -EFAULT;
@@ -376,9 +375,7 @@ static int _dpu_format_populate_addrs_linear(
 
        /* Populate addresses for simple formats here */
        for (i = 0; i < layout->num_planes; ++i) {
-               if (aspace)
-                       layout->plane_addr[i] =
-                               msm_framebuffer_iova(fb, aspace, i);
+               layout->plane_addr[i] = msm_framebuffer_iova(fb, aspace, i);
                if (!layout->plane_addr[i]) {
                        DRM_ERROR("failed to retrieve base addr\n");
                        return -EFAULT;

-- 
2.39.2

Reply via email to