On 7/15/2025 10:28 AM, Dmitry Baryshkov wrote:
Fix c&p error in dpu_plane_virtual_atomic_check(), compare CRTC width
too, in addition to CRTC height.

Fixes: 8c62a31607f6 ("drm/msm/dpu: allow using two SSPP blocks for a single 
plane")
Reported-by: kernel test robot <l...@intel.com>
Closes: 
https://lore.kernel.org/oe-kbuild-all/202507150432.u0calr6w-...@intel.com/
Signed-off-by: Dmitry Baryshkov <dmitry.barysh...@oss.qualcomm.com>

Reviewed-by: Jessica Zhang <jessica.zh...@oss.qualcomm.com>

---
  drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c 
b/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c
index 
01171c535a27c8983aab6450d6f7a4316ae9c4ee..c722f54e71b03b78f3de82fec4f2d291d95bbba3
 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c
@@ -1162,7 +1162,7 @@ static int dpu_plane_virtual_atomic_check(struct 
drm_plane *plane,
        if (!old_plane_state || !old_plane_state->fb ||
            old_plane_state->src_w != plane_state->src_w ||
            old_plane_state->src_h != plane_state->src_h ||
-           old_plane_state->src_w != plane_state->src_w ||
+           old_plane_state->crtc_w != plane_state->crtc_w ||
            old_plane_state->crtc_h != plane_state->crtc_h ||
            msm_framebuffer_format(old_plane_state->fb) !=
            msm_framebuffer_format(plane_state->fb))

---
base-commit: 8290d37ad2b087bbcfe65fa5bcaf260e184b250a
change-id: 20250715-msm-fix-virt-atomic-check-ae38fcfd9e08

Best regards,

Reply via email to