URL: https://github.com/freeipa/freeipa/pull/817
Author: stlaz
 Title: #817: [py3] Change ConfigParser to RawConfigParser
Action: opened

PR body:
"""
In case ipa_generate_password() generates a sequence containing
'%', ConfigParser.set() will fail because it would think it is a
string that should be interpolated.

https://pagure.io/freeipa/issue/4985
"""

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/817/head:pr817
git checkout pr817
From cca1626abd041df9cb302a727418a77f424e690f Mon Sep 17 00:00:00 2001
From: Stanislav Laznicka <slazn...@redhat.com>
Date: Thu, 25 May 2017 14:18:11 +0200
Subject: [PATCH] Change ConfigParser to RawConfigParser

In case ipa_generate_password() generates a sequence containing
'%', ConfigParser.set() will fail because it would think it is a
string that should be interpolated.

https://pagure.io/freeipa/issue/4985
---
 ipaserver/install/cainstance.py  | 4 ++--
 ipaserver/install/krainstance.py | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/ipaserver/install/cainstance.py b/ipaserver/install/cainstance.py
index b0e9e8757e..0b313691c3 100644
--- a/ipaserver/install/cainstance.py
+++ b/ipaserver/install/cainstance.py
@@ -36,7 +36,7 @@
 
 import six
 # pylint: disable=import-error
-from six.moves.configparser import ConfigParser, RawConfigParser
+from six.moves.configparser import RawConfigParser
 # pylint: enable=import-error
 from cryptography.hazmat.primitives import serialization
 
@@ -465,7 +465,7 @@ def __spawn_instance(self):
         self.tmp_agent_pwd = ipautil.ipa_generate_password()
 
         # Create CA configuration
-        config = ConfigParser()
+        config = RawConfigParser()
         config.optionxform = str
         config.add_section("CA")
 
diff --git a/ipaserver/install/krainstance.py b/ipaserver/install/krainstance.py
index cdd25b9d05..52d6273114 100644
--- a/ipaserver/install/krainstance.py
+++ b/ipaserver/install/krainstance.py
@@ -24,7 +24,7 @@
 
 import six
 # pylint: disable=import-error
-from six.moves.configparser import ConfigParser
+from six.moves.configparser import RawConfigParser
 # pylint: enable=import-error
 from cryptography.hazmat.primitives import serialization
 
@@ -153,7 +153,7 @@ def __spawn_instance(self):
         tmp_agent_pwd = ipautil.ipa_generate_password()
 
         # Create KRA configuration
-        config = ConfigParser()
+        config = RawConfigParser()
         config.optionxform = str
         config.add_section("KRA")
 
_______________________________________________
FreeIPA-devel mailing list -- freeipa-devel@lists.fedorahosted.org
To unsubscribe send an email to freeipa-devel-le...@lists.fedorahosted.org

Reply via email to