URL: https://github.com/freeipa/freeipa/pull/845 Author: stlaz Title: #845: ipadiscovery: Return realm as a string Action: opened
PR body: """ We don't have a use for realm as a bytes instance, return it as a string, otherwise there's a use of str() on bytes in py3. https://pagure.io/freeipa/issue/4985 """ To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/845/head:pr845 git checkout pr845
From b002bdeeabf21a5a9b4f64de7ef92e7614aadce5 Mon Sep 17 00:00:00 2001 From: Stanislav Laznicka <slazn...@redhat.com> Date: Fri, 2 Jun 2017 08:05:02 +0200 Subject: [PATCH] ipadiscovery: Return realm as a string We don't have a use for realm as a bytes instance, return it as a string, otherwise there's a use of str() on bytes in py3. https://pagure.io/freeipa/issue/4985 --- ipaclient/install/ipadiscovery.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ipaclient/install/ipadiscovery.py b/ipaclient/install/ipadiscovery.py index c929a35a80..b219b504cb 100644 --- a/ipaclient/install/ipadiscovery.py +++ b/ipaclient/install/ipadiscovery.py @@ -531,7 +531,7 @@ def ipadnssearchkrbrealm(self, domain=None): for answer in answers: root_logger.debug("DNS record found: %s", answer) if answer.strings: - realm = answer.strings[0] + realm = answer.strings[0].decode('utf-8') if realm: break return realm
_______________________________________________ FreeIPA-devel mailing list -- freeipa-devel@lists.fedorahosted.org To unsubscribe send an email to freeipa-devel-le...@lists.fedorahosted.org
