URL: https://github.com/freeipa/freeipa/pull/1324
Author: tiran
 Title: #1324: Fix  dnsrecord_show for structured record
Action: opened

PR body:
"""
https://pagure.io/freeipa/issue/7275

Signed-off-by: Christian Heimes <chei...@redhat.com>
"""

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/1324/head:pr1324
git checkout pr1324
From 838f57f4d2a329d9e85fe582327fef68b5b29bec Mon Sep 17 00:00:00 2001
From: Christian Heimes <chei...@redhat.com>
Date: Wed, 22 Nov 2017 17:30:58 +0100
Subject: [PATCH] Fix  dnsrecord_show for structured record

https://pagure.io/freeipa/issue/7275

Signed-off-by: Christian Heimes <chei...@redhat.com>
---
 ipatests/test_xmlrpc/test_dns_plugin.py | 19 +++++++++++++++++--
 1 file changed, 17 insertions(+), 2 deletions(-)

diff --git a/ipatests/test_xmlrpc/test_dns_plugin.py b/ipatests/test_xmlrpc/test_dns_plugin.py
index 68d7c4ae29..d4fbe2dba4 100644
--- a/ipatests/test_xmlrpc/test_dns_plugin.py
+++ b/ipatests/test_xmlrpc/test_dns_plugin.py
@@ -2820,7 +2820,7 @@ def setup_class(cls):
 
         dict(
             desc='Show raw record %r in zone %r' % (u'_foo._tcp', idnzone1),
-            command=('dnsrecord_show', [idnzone1, u'_foo._tcp'], {u'raw' : True}),
+            command=('dnsrecord_show', [idnzone1, u'_foo._tcp'], {u'raw': True}),
             expected={
                 'value': DNSName(u'_foo._tcp'),
                 'summary': None,
@@ -2834,7 +2834,7 @@ def setup_class(cls):
 
         dict(
             desc='Show raw record %r in zone %r' % (u'_foo._tcp', idnzone1_punycoded),
-            command=('dnsrecord_show', [idnzone1, u'_foo._tcp'], {u'raw' : True}),
+            command=('dnsrecord_show', [idnzone1, u'_foo._tcp'], {u'raw': True}),
             expected={
                 'value': DNSName(u'_foo._tcp'),
                 'summary': None,
@@ -2846,6 +2846,21 @@ def setup_class(cls):
             },
         ),
 
+        dict(
+            desc='Show structured record %r in zone %r' % (u'_foo._tcp', idnzone1),
+            command=('dnsrecord_show', [idnzone1, u'_foo._tcp'],
+                     {u'rights': True, u'structured': True, u'all': True}),
+            expected={
+                'value': DNSName(u'_foo._tcp'),
+                'summary': None,
+                'result': {
+                    'dn': DN(('idnsname', u'_foo._tcp'), idnzone1_dn),
+                    'idnsname': [u'_foo._tcp'],
+                    'srvrecord': [
+                        u"0 100 1234 %s" % idnzone1_mname_punycoded],
+                },
+            },
+        ),
 
         dict(
             desc='Add AFSDB record to %r using dnsrecord_add' % (dnsafsdbres1),
_______________________________________________
FreeIPA-devel mailing list -- freeipa-devel@lists.fedorahosted.org
To unsubscribe send an email to freeipa-devel-le...@lists.fedorahosted.org

Reply via email to