URL: https://github.com/freeipa/freeipa/pull/1694
Author: gkaihorodova
 Title: #1694: Fix for test TestInstallMasterReservedIPasForwarder
Action: opened

PR body:
"""
 Minor fix to enable test case for proper run in our testing environment

"""

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/1694/head:pr1694
git checkout pr1694
From b3960169cf8cf151742d89825717fe80e0e6a94c Mon Sep 17 00:00:00 2001
From: Ganna Kaihorodova <gkaih...@redhat.com>
Date: Tue, 20 Feb 2018 12:09:20 +0100
Subject: [PATCH 1/2] Overide trust methods for integration tests

Overide trust method test_establish_trust_with_posix_attributes to test_establish_trust.
Windows Server 2016 doesn't have support for MFU/NIS, so autodetection is not working

https://pagure.io/freeipa/issue/7313
---
 ipatests/test_integration/test_trust.py | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/ipatests/test_integration/test_trust.py b/ipatests/test_integration/test_trust.py
index ccdc2e3d42..abce2aec78 100644
--- a/ipatests/test_integration/test_trust.py
+++ b/ipatests/test_integration/test_trust.py
@@ -258,8 +258,11 @@ class TestEnforcedPosixADTrust(TestPosixADTrust):
     This test is intented to copycat PosixADTrust, since enforcing the POSIX
     trust type should not make a difference.
     """
+    """Re-difene method from test_establish_trust_with_posix_attributes
+    to test_establish_trust. win server 2016 no more have support for MFU/NIS,
+    so autodetection doesn't work"""
 
-    def test_establish_trust_with_posix_attributes(self):
+    def test_establish_trust(self):
         tasks.establish_trust_with_ad(self.master, self.ad_domain,
             extra_args=['--range-type', 'ipa-ad-trust-posix'])
 

From 65a31e21daa18d2b8a5db7319189de5273fc5910 Mon Sep 17 00:00:00 2001
From: Ganna Kaihorodova <gkaih...@redhat.com>
Date: Thu, 15 Mar 2018 14:59:33 +0100
Subject: [PATCH 2/2] Fix for test TestInstallMasterReservedIPasForwarder

Minor fix to enable test case for proper run in our testing environment

Minor test fix for
---
 ipatests/test_integration/test_installation.py | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/ipatests/test_integration/test_installation.py b/ipatests/test_integration/test_installation.py
index 0bca96faa3..514be6e37b 100644
--- a/ipatests/test_integration/test_installation.py
+++ b/ipatests/test_integration/test_installation.py
@@ -345,12 +345,14 @@ def test_reserved_ip_as_forwarder(self):
         assert exp_str in cmd.stderr_text
 
         server_install_options = (
-                "yes\n\n\n\n"
+                "yes\n"
+                "{dmname}\n\n"
                 "{dm_pass}\n{dm_pass}"
                 "\n{admin_pass}\n{admin_pass}\n"
                 "yes\nyes\n0.0.0.0\n".format(
                     dm_pass=self.master.config.dirman_password,
-                    admin_pass=self.master.config.admin_password))
+                    admin_pass=self.master.config.admin_password,
+                    dmname=self.master.domain.name))
 
         cmd = self.master.run_command(['ipa-server-install'],
                                       stdin_text=server_install_options,
_______________________________________________
FreeIPA-devel mailing list -- freeipa-devel@lists.fedorahosted.org
To unsubscribe send an email to freeipa-devel-le...@lists.fedorahosted.org

Reply via email to