URL: https://github.com/freeipa/freeipa/pull/1966 Author: tiran Title: #1966: [Backport][ipa-4-6] Don't try to set Kerberos extradata when there is no principal Action: opened
PR body: """ This was causing ns-slapd to segfault in the password plugin. https://pagure.io/freeipa/issue/7561 Signed-off-by: Rob Crittenden <rcrit...@redhat.com> """ To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/1966/head:pr1966 git checkout pr1966
From a5736ede2d43b7dedb78722ae93e85128c53e138 Mon Sep 17 00:00:00 2001 From: Rob Crittenden <rcrit...@redhat.com> Date: Wed, 23 May 2018 16:30:09 -0400 Subject: [PATCH] Don't try to set Kerberos extradata when there is no principal This was causing ns-slapd to segfault in the password plugin. https://pagure.io/freeipa/issue/7561 Signed-off-by: Rob Crittenden <rcrit...@redhat.com> Reviewed-By: Rob Crittenden <rcrit...@redhat.com> --- daemons/ipa-slapi-plugins/ipa-pwd-extop/ipa_pwd_extop.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/daemons/ipa-slapi-plugins/ipa-pwd-extop/ipa_pwd_extop.c b/daemons/ipa-slapi-plugins/ipa-pwd-extop/ipa_pwd_extop.c index bdb7ee8597..7e52a8855a 100644 --- a/daemons/ipa-slapi-plugins/ipa-pwd-extop/ipa_pwd_extop.c +++ b/daemons/ipa-slapi-plugins/ipa-pwd-extop/ipa_pwd_extop.c @@ -595,7 +595,8 @@ static int ipapwd_chpwop(Slapi_PBlock *pb, struct ipapwd_krbcfg *krbcfg) } else { principal = slapi_ch_smprintf("root/admin@%s", krbcfg->realm); } - ipapwd_set_extradata(pwdata.dn, principal, pwdata.timeNow); + if (principal) + ipapwd_set_extradata(pwdata.dn, principal, pwdata.timeNow); /* Free anything that we allocated above */ free_and_return:
_______________________________________________ FreeIPA-devel mailing list -- freeipa-devel@lists.fedorahosted.org To unsubscribe send an email to freeipa-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/freeipa-devel@lists.fedorahosted.org/message/IRHV437K4JSKLYXMUO7XHN6TWRXHSS2Y/
