URL: https://github.com/freeipa/freeipa/pull/2235 Author: t-woerner Title: #2235: ipaclient: Remove --no-sssd and --no-ac options Action: opened
PR body: """ Client installation with --no-sssd option has already beeen deprecated with https://pagure.io/freeipa/issue/5860. Authconfig support has been removed, therefore --no-ac option can be removed also. ipatests/test_integration/test_authselect.py: Skip no_sssd and no_ac tests. See: https://pagure.io/freeipa/issue/7671 Signed-off-by: Thomas Woerner <twoer...@redhat.com> """ To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/2235/head:pr2235 git checkout pr2235
From 44bfa588f23dd127d52dea091d71220f00bd1285 Mon Sep 17 00:00:00 2001 From: Thomas Woerner <twoer...@redhat.com> Date: Thu, 9 Aug 2018 12:05:26 +0200 Subject: [PATCH] ipaclient: Remove --no-sssd and --no-ac options Client installation with --no-sssd option has already beeen deprecated with https://pagure.io/freeipa/issue/5860. Authconfig support has been removed, therefore --no-ac option can be removed also. ipatests/test_integration/test_authselect.py: Skip no_sssd and no_ac tests. See: https://pagure.io/freeipa/issue/7671 Signed-off-by: Thomas Woerner <twoer...@redhat.com> --- ipaclient/install/client.py | 6 +----- ipaclient/install/sssd.py | 9 +-------- ipatests/test_integration/test_authselect.py | 2 ++ 3 files changed, 4 insertions(+), 13 deletions(-) diff --git a/ipaclient/install/client.py b/ipaclient/install/client.py index 627351ac21..800a467340 100644 --- a/ipaclient/install/client.py +++ b/ipaclient/install/client.py @@ -3709,11 +3709,7 @@ def ca_cert_files(self, value): def prompt_password(self): return self.interactive - no_ac = knob( - None, - description="do not modify the nsswitch.conf and PAM configuration", - cli_names='--noac', - ) + no_ac = False force = knob( None, diff --git a/ipaclient/install/sssd.py b/ipaclient/install/sssd.py index b20abde56f..98b8504643 100644 --- a/ipaclient/install/sssd.py +++ b/ipaclient/install/sssd.py @@ -43,11 +43,4 @@ class SSSDInstallInterface(service.ServiceInstallInterface): ) preserve_sssd = enroll_only(preserve_sssd) - no_sssd = knob( - None, - deprecated=True, - description="Do not configure the client to use SSSD for " - "authentication", - cli_names=[None, '-S'], - ) - no_sssd = enroll_only(no_sssd) + no_sssd = False diff --git a/ipatests/test_integration/test_authselect.py b/ipatests/test_integration/test_authselect.py index fa9b202654..ebf3d98922 100644 --- a/ipatests/test_integration/test_authselect.py +++ b/ipatests/test_integration/test_authselect.py @@ -88,6 +88,7 @@ def _uninstall_client(self): ['ipa-client-install', '--uninstall', '-U'], raiseonerr=False) + @pytest.mark.skip(reason="Option --no-sssd has been removed") def test_install_client_no_sssd(self): """ Test client installation with --no-sssd option. @@ -98,6 +99,7 @@ def test_install_client_no_sssd(self): msg = "Option '--no-sssd' is incompatible with the 'authselect' tool" assert msg in result.stderr_text + @pytest.mark.skip(reason="Option --noac has been removed") def test_install_client_no_ac(self): """ Test client installation with --noac option.
_______________________________________________ FreeIPA-devel mailing list -- freeipa-devel@lists.fedorahosted.org To unsubscribe send an email to freeipa-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/freeipa-devel@lists.fedorahosted.org/message/XC7H5FJD2KBUROR7UCRWYIODCDEH5XWM/
