URL: https://github.com/freeipa/freeipa/pull/4485 Author: flo-renaud Title: #4485: ipatests: fix covscan issue in test_otp.py Action: opened
PR body: """ Fixes: https://pagure.io/freeipa/issue/8255 """ To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/4485/head:pr4485 git checkout pr4485
From 802adddbd0db627c1f7cb35a098d80de8652212f Mon Sep 17 00:00:00 2001 From: Florence Blanc-Renaud <f...@redhat.com> Date: Thu, 2 Apr 2020 15:40:10 +0200 Subject: [PATCH 1/2] ipatests: fix covscan issue in test_otp.py Fixes: https://pagure.io/freeipa/issue/8255 --- ipatests/test_integration/test_otp.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ipatests/test_integration/test_otp.py b/ipatests/test_integration/test_otp.py index 036b8d12c7..1a14039628 100644 --- a/ipatests/test_integration/test_otp.py +++ b/ipatests/test_integration/test_otp.py @@ -97,7 +97,7 @@ def answer_handler(title, instructions, prompt_list): if title: logger.info(title.strip()) if instructions: - logger.info(title.strip()) + logger.info(instructions.strip()) for prmpt in prompt_list: prmpt_str = prmpt[0].strip() resp.append(answers_dict[prmpt_str]) From a75fe7fb349fd8490b9bd464093b53350180790a Mon Sep 17 00:00:00 2001 From: Florence Blanc-Renaud <f...@redhat.com> Date: Thu, 2 Apr 2020 15:43:14 +0200 Subject: [PATCH 2/2] Temp commit to test the fix, please remove before pushing --- .freeipa-pr-ci.yaml | 2 +- ipatests/prci_definitions/temp_commit.yaml | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.freeipa-pr-ci.yaml b/.freeipa-pr-ci.yaml index abcf8c5b63..8065669008 120000 --- a/.freeipa-pr-ci.yaml +++ b/.freeipa-pr-ci.yaml @@ -1 +1 @@ -ipatests/prci_definitions/gating.yaml \ No newline at end of file +ipatests/prci_definitions/temp_commit.yaml \ No newline at end of file diff --git a/ipatests/prci_definitions/temp_commit.yaml b/ipatests/prci_definitions/temp_commit.yaml index cc5737a848..a6a1490d20 100644 --- a/ipatests/prci_definitions/temp_commit.yaml +++ b/ipatests/prci_definitions/temp_commit.yaml @@ -62,14 +62,14 @@ jobs: timeout: 1800 topology: *build - fedora-27/temp_commit: + fedora-27/test_otp: requires: [fedora-27/build] priority: 50 job: class: RunPytest args: build_url: '{fedora-27/build_url}' - test_suite: test_integration/test_REPLACEME.py + test_suite: test_integration/test_otp.py template: *ci-master-f27 timeout: 3600 - topology: *master_1repl_1client + topology: *master_1repl
_______________________________________________ FreeIPA-devel mailing list -- freeipa-devel@lists.fedorahosted.org To unsubscribe send an email to freeipa-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/freeipa-devel@lists.fedorahosted.org
