URL: https://github.com/freeipa/freeipa/pull/4508
Author: fcami
 Title: #4508: Fix test ipa commands run as aduser assert
Action: opened

PR body:
"""
test_trust.py::test_ipa_commands_run_as_aduser expects
'ipa: ERROR: Insufficient access: SASL(-14):'
'authorization failure: Invalid credentials'
but the correct string is:
'ipa: ERROR: Insufficient access:  Invalid credentials'
Change assert.
    
Fixes: https://pagure.io/freeipa/issue/8263

"""

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/4508/head:pr4508
git checkout pr4508
From 5a38cbd8a5bf9e8c3231ba570a26a3954bdf108d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Fran=C3=A7ois=20Cami?= <fc...@redhat.com>
Date: Wed, 8 Apr 2020 10:45:16 +0200
Subject: [PATCH 1/2] ipatests: fix test_ipa_commands_run_as_aduser assert
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

test_trust.py::test_ipa_commands_run_as_aduser expects
'ipa: ERROR: Insufficient access: SASL(-14):'
'authorization failure: Invalid credentials'
but the correct string is:
'ipa: ERROR: Insufficient access:  Invalid credentials'
Change assert.

Fixes: https://pagure.io/freeipa/issue/8263
Signed-off-by: François Cami <fc...@redhat.com>
---
 ipatests/test_integration/test_trust.py | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/ipatests/test_integration/test_trust.py b/ipatests/test_integration/test_trust.py
index 0f31927dd5..82065580fc 100644
--- a/ipatests/test_integration/test_trust.py
+++ b/ipatests/test_integration/test_trust.py
@@ -141,8 +141,7 @@ def test_ipa_commands_run_as_aduser(self):
         ad_admin = 'Administrator@%s' % self.ad_domain
         tasks.kinit_as_user(self.master, ad_admin,
                             self.master.config.ad_admin_password)
-        err_string = ('ipa: ERROR: Insufficient access: SASL(-14):'
-                      ' authorization failure: Invalid credentials')
+        err_string = ('ipa: ERROR: Insufficient access:  Invalid credentials')
         result = self.master.run_command(['ipa', 'ping'], raiseonerr=False)
         assert err_string in result.stderr_text
 

From 692f6ef5216e5172b2d40c99e73b5652f3454bd7 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Fran=C3=A7ois=20Cami?= <fc...@redhat.com>
Date: Wed, 8 Apr 2020 12:31:23 +0200
Subject: [PATCH 2/2] temp commit

---
 .freeipa-pr-ci.yaml                        |  2 +-
 ipatests/prci_definitions/temp_commit.yaml | 10 +++++-----
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/.freeipa-pr-ci.yaml b/.freeipa-pr-ci.yaml
index abcf8c5b63..8065669008 120000
--- a/.freeipa-pr-ci.yaml
+++ b/.freeipa-pr-ci.yaml
@@ -1 +1 @@
-ipatests/prci_definitions/gating.yaml
\ No newline at end of file
+ipatests/prci_definitions/temp_commit.yaml
\ No newline at end of file
diff --git a/ipatests/prci_definitions/temp_commit.yaml b/ipatests/prci_definitions/temp_commit.yaml
index 6bb37ca6dc..eef8788297 100644
--- a/ipatests/prci_definitions/temp_commit.yaml
+++ b/ipatests/prci_definitions/temp_commit.yaml
@@ -61,14 +61,14 @@ jobs:
         timeout: 1800
         topology: *build
 
-  fedora-latest/temp_commit:
+  fedora-latest/test_trust:
     requires: [fedora-latest/build]
     priority: 50
     job:
-      class: RunPytest
+      class: RunADTests
       args:
         build_url: '{fedora-latest/build_url}'
-        test_suite: test_integration/test_REPLACEME.py
+        test_suite: test_integration/test_trust.py
         template: *ci-master-latest
-        timeout: 3600
-        topology: *master_1repl_1client
+        timeout: 7200
+        topology: *adroot_adchild_adtree_master_1client
_______________________________________________
FreeIPA-devel mailing list -- freeipa-devel@lists.fedorahosted.org
To unsubscribe send an email to freeipa-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/freeipa-devel@lists.fedorahosted.org

Reply via email to