URL: https://github.com/freeipa/freeipa/pull/4943 Author: rcritten Title: #4943: Fix for two failing healthcheck tests Action: opened
PR body: """ The release of freeipa-healthcheck 0.6 fixes a problem and introduces a new one. It adds namespacing so we can limit the checks and avoid spurious errors from the PKI healthchecks that miscount the number of errors when all services are stopped. It also pulls in checks provided by lib389. Change the naming of Replication error checking. NOTE: this will not test green until a new release of healthcheck is made in Fedora to address two other issues introduced with 0.6 that also cause spurious errors when all services are stopped. """ To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/4943/head:pr4943 git checkout pr4943
From ec7f86321c4b6faae73a82e3c1ba15fdbacbda9f Mon Sep 17 00:00:00 2001 From: Rob Crittenden <[email protected]> Date: Wed, 22 Jul 2020 11:47:23 -0400 Subject: [PATCH 1/2] ipatests: lib389 is now providing healthchecks, update naming --- ipatests/test_integration/test_ipahealthcheck.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ipatests/test_integration/test_ipahealthcheck.py b/ipatests/test_integration/test_ipahealthcheck.py index 729a685284..246fec859a 100644 --- a/ipatests/test_integration/test_ipahealthcheck.py +++ b/ipatests/test_integration/test_ipahealthcheck.py @@ -89,7 +89,7 @@ ipafiles_checks = ["IPAFileNSSDBCheck", "IPAFileCheck", "TomcatFileCheck"] dogtag_checks = ["DogtagCertsConfigCheck", "DogtagCertsConnectivityCheck"] iparoles_checks = ["IPACRLManagerCheck", "IPARenewalMasterCheck"] -replication_checks = ["ReplicationConflictCheck"] +replication_checks = ["ReplicationCheck"] ruv_checks = ["RUVCheck"] dna_checks = ["IPADNARangeCheck"] idns_checks = ["IPADNSSystemRecordsCheck"] From 52dbf76cd93b3d342be2978b99bea4fd0820c03b Mon Sep 17 00:00:00 2001 From: Rob Crittenden <[email protected]> Date: Fri, 24 Jul 2020 10:09:35 -0400 Subject: [PATCH 2/2] ipatests: Use healthcheck namespacing in stopped server test The test_run_with_stopped_master() test runs ipactl stop and then verifies that all the errors relate to the services not being available. The newly integrated PKI tests also report errors in this case. Use the namespacing introduced in freeipa-healthcheck-0.6 to limit the execution to the ipahealthcheck.meta checks to avoid the spurious PKI errors. Signed-off-by: Rob Crittenden <[email protected]> --- ipatests/test_integration/test_ipahealthcheck.py | 1 + 1 file changed, 1 insertion(+) diff --git a/ipatests/test_integration/test_ipahealthcheck.py b/ipatests/test_integration/test_ipahealthcheck.py index 246fec859a..7a3efd5851 100644 --- a/ipatests/test_integration/test_ipahealthcheck.py +++ b/ipatests/test_integration/test_ipahealthcheck.py @@ -717,6 +717,7 @@ def test_run_with_stopped_master(self, ipactl): """ returncode, output = run_healthcheck( self.master, + "ipahealthcheck.meta", output_type="human", failures_only=True) assert returncode == 1
_______________________________________________ FreeIPA-devel mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/[email protected]
