URL: https://github.com/freeipa/freeipa/pull/4952
Author: fcami
 Title: #4952: [Backport][ipa-4-8] re-enable test_sss_ssh_authorizedkeys
Action: opened

PR body:
"""
test_sss_ssh_authorizedkeys was disabled but recent test runs show it might be 
working properly.
Run in multiple times to see if it works.

Note two commits: I'd rather keep the -v even if we end up disabling the test 
again, so these commits should not be squashed.
"""

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/4952/head:pr4952
git checkout pr4952
From d0d24c7745a8433a6d228f663cc18e6f778c6e84 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Fran=C3=A7ois=20Cami?= <[email protected]>
Date: Thu, 23 Jul 2020 15:11:13 +0200
Subject: [PATCH 1/2] ipatests: re-enable test_sss_ssh_authorizedkeys
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Re-enable test_sss_ssh_authorizedkeys.

Related: https://pagure.io/freeipa/issue/8151
Signed-off-by: François Cami <[email protected]>
Reviewed-By: Armando Neto <[email protected]>
---
 ipatests/test_integration/test_commands.py | 1 -
 1 file changed, 1 deletion(-)

diff --git a/ipatests/test_integration/test_commands.py b/ipatests/test_integration/test_commands.py
index bacde50416..bfb637cae5 100644
--- a/ipatests/test_integration/test_commands.py
+++ b/ipatests/test_integration/test_commands.py
@@ -1023,7 +1023,6 @@ def is_tls_version_enabled(tls_version):
         assert is_tls_version_enabled('tls1_2')
         assert is_tls_version_enabled('tls1_3')
 
-    @pytest.mark.skip(reason='https://pagure.io/freeipa/issue/8151')
     def test_sss_ssh_authorizedkeys(self):
         """Login via Ssh using private-key for ipa-user should work.
 

From 933d1b577454ee5ddf69d65979ef20d3e45c9af3 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Fran=C3=A7ois=20Cami?= <[email protected]>
Date: Thu, 23 Jul 2020 15:13:04 +0200
Subject: [PATCH 2/2] ipatests: test_sss_ssh_authorizedkeys
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Add debug information to the ssh invocation.

Related: https://pagure.io/freeipa/issue/8151
Signed-off-by: François Cami <[email protected]>
Reviewed-By: Armando Neto <[email protected]>
---
 ipatests/test_integration/test_commands.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ipatests/test_integration/test_commands.py b/ipatests/test_integration/test_commands.py
index bfb637cae5..184a70d8d3 100644
--- a/ipatests/test_integration/test_commands.py
+++ b/ipatests/test_integration/test_commands.py
@@ -1067,7 +1067,7 @@ def test_sss_ssh_authorizedkeys(self):
             assert ssh_pub_key in result.stdout_text
             # login to the system
             self.master.run_command(
-                ['ssh', '-o', 'PasswordAuthentication=no',
+                ['ssh', '-v', '-o', 'PasswordAuthentication=no',
                  '-o', 'IdentitiesOnly=yes', '-o', 'StrictHostKeyChecking=no',
                  '-o', 'ConnectTimeout=10', '-l', user, '-i', user_key,
                  self.master.hostname, 'true'])
_______________________________________________
FreeIPA-devel mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/[email protected]

Reply via email to