URL: https://github.com/freeipa/freeipa/pull/6111 Author: mrizwan93 Title: #6111: ipatests: Fix test_ipa_cert_fix.py::TestCertFixReplica teardown Action: opened
PR body: """ Fixture `expire_certs` moves date back after renewing the certs. This is causing the ipa-replica to fail. This fix first uninstalls the server then moves back the date. related: https://pagure.io/freeipa/issue/9052 Signed-off-by: Mohammad Rizwan <myu...@redhat.com> """ To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/6111/head:pr6111 git checkout pr6111
From a34a1e1ecd135d8f313b1c60a4c5a74509f77786 Mon Sep 17 00:00:00 2001 From: Mohammad Rizwan <myu...@redhat.com> Date: Fri, 26 Nov 2021 12:11:21 +0530 Subject: [PATCH 1/2] ipatests: Fix test_ipa_cert_fix.py::TestCertFixReplica teardown Fixture `expire_certs` moves date back after renewing the certs. This is causing the ipa-replica to fail. This fix first uninstalls the server then moves back the date. related: https://pagure.io/freeipa/issue/9052 Signed-off-by: Mohammad Rizwan <myu...@redhat.com> --- ipatests/test_integration/test_ipa_cert_fix.py | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/ipatests/test_integration/test_ipa_cert_fix.py b/ipatests/test_integration/test_ipa_cert_fix.py index 39904d5de64..5b56054b4f1 100644 --- a/ipatests/test_integration/test_ipa_cert_fix.py +++ b/ipatests/test_integration/test_ipa_cert_fix.py @@ -389,6 +389,12 @@ def install(cls, mh): setup_dns=False, extra_args=['--no-ntp'] ) + @classmethod + def uninstall(cls, mh): + # Uninstall method is empty as the uninstallation is done in + # the fixture + pass + @pytest.fixture def expire_certs(self): # move system date to expire certs @@ -398,7 +404,8 @@ def expire_certs(self): yield # move date back on replica and master - for host in self.master, self.replicas[0]: + for host in self.replicas[0], self.master: + tasks.uninstall_master(host) tasks.move_date(host, 'start', '-3years-1days') def test_renew_expired_cert_replica(self, expire_certs): From 8cb172f700c3b69604a9c8644d599c7e606e1e0f Mon Sep 17 00:00:00 2001 From: Mohammad Rizwan <myu...@redhat.com> Date: Fri, 26 Nov 2021 12:15:38 +0530 Subject: [PATCH 2/2] temp commit --- .freeipa-pr-ci.yaml | 2 +- ipatests/prci_definitions/temp_commit.yaml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.freeipa-pr-ci.yaml b/.freeipa-pr-ci.yaml index abcf8c5b634..80656690080 120000 --- a/.freeipa-pr-ci.yaml +++ b/.freeipa-pr-ci.yaml @@ -1 +1 @@ -ipatests/prci_definitions/gating.yaml \ No newline at end of file +ipatests/prci_definitions/temp_commit.yaml \ No newline at end of file diff --git a/ipatests/prci_definitions/temp_commit.yaml b/ipatests/prci_definitions/temp_commit.yaml index 31935bf044a..7fa47d63a5f 100644 --- a/ipatests/prci_definitions/temp_commit.yaml +++ b/ipatests/prci_definitions/temp_commit.yaml @@ -68,7 +68,7 @@ jobs: class: RunPytest args: build_url: '{fedora-latest/build_url}' - test_suite: test_integration/test_REPLACEME.py + test_suite: test_integration/test_ipa_cert_fix.py::TestCertFixReplica template: *ci-master-latest timeout: 3600 topology: *master_1repl_1client
_______________________________________________ FreeIPA-devel mailing list -- freeipa-devel@lists.fedorahosted.org To unsubscribe send an email to freeipa-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/freeipa-devel@lists.fedorahosted.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
