-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 01/10/2011 09:40 AM, Martin Kosek wrote: > On Fri, 2011-01-07 at 11:26 -0500, Adam Young wrote: >> Is there any chance that the point-to-a-pointer parameters will have >> valid values other than null passed in? Almost seems that by >> initializing them to null, you might be masking a memory leak. >> >> If not, then ACK > > Hello Adam, > > it is safe as these pointers are initialized to NULL in function > join(...) and then passed without any change to functions join_ldap() or > join_krb5(). > > If these pointers did held some allocated memory we would have had a > leak anyway - xmlrpc_read_string() function overwrites the pointers with > own allocated memory holding the desired output. > > Martin >
Nack, if(ptr) free(ptr); is redundant, freeing a NULL pointer is a no-op. Other that that, looks fine. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/ iEYEARECAAYFAk0q9dcACgkQHsardTLnvCWf4wCgxy9LKqZzwuUaXMOD1agggkLq 8MIAnAqTxX2CZhate0kp4HAcUOcNyQc6 =uBSK -----END PGP SIGNATURE----- _______________________________________________ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
