On 02/21/2011 11:05 AM, Endi Sukma Dewata wrote:
On 2/21/2011 9:25 AM, Adam Young wrote:
I haven't got a chance to provide a long explanation for this, but
please try to apply all patches that I've submitted (until 109) and
see the user.js, group.js and certificate.js. I think they are clearly
structured and easy to understand.
Try to think "plugins" as "modules", and "init()" as "start()" or
"main()", or some other terms. Once all entity files are converted to
use this framework, it maybe possible to remove init() from
entity/facet/widget. The init() is not an unnecessary duplication of
constructor, but it's a callback to indicate that the messages are
loaded.
OK, just completed a more in depth review. I stand by my origianl call.
I don't want to make a change like this in the 2.0 timeframe. When we do
make the change, it will incorporate some of these ideas, but we are not
going to use the deliberate init() call.
For now, just make the libraries for cert etc as lazy load accessors
like I recommended earlier. It should be a pretty short addition to
Patch 106-2. Hold on to the changes from patches 106-3 on and we will
design a more complete refactoring target for the 2.1 release.
Attached is an updated patch with the IPA.plugin framework removed.
For now I'm just using the same method used for IPA.sudo, using a
plain hash table. The IPA.cert.CRL_REASON for now is hard-coded. Let's
get this patch and 107 in first because they really should go together
with patch 105 which is already pushed. Please submit your registry
code as a separate patch, it shouldn't be combined with these i18n
fixes. Thanks!
ACK and pushed to master.
_______________________________________________
Freeipa-devel mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/freeipa-devel
