-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 02/23/2011 04:47 PM, Rob Crittenden wrote: > Jakub Hrozek wrote: >> Replace only if old and new have nothing in common >> > > This has problems when removing the last member. There is no adds, rems > has a single value (the member being removed). The intersection is 0 so > force_replace gets set to True and nothing ends up getting done. > > I added a len(v) > 0 to this conditional and it seems to work. I also > added a small test case based on Endi's initial report. I'm getting a > 100% test pass rate. > > rob
I hit one more problem with the patch, although I'm not entirely sure how is that possible - when a user is renamed, his memberof becomes indirect memberof: # ipa user-mod --rename test2 test - -------------------- Modified user "test" - -------------------- User login: test2 First name: Test Last name: User Home directory: /home/test Login shell: /bin/sh Account disabled: False Indirect Member of group: ipausers -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/ iEYEARECAAYFAk1lQFUACgkQHsardTLnvCUNDwCghhM7z5y0sZkYAd6LWbtpPsuY ua4AoJbugnFeCADOG91nm5PJcNfshCgQ =pHWV -----END PGP SIGNATURE----- _______________________________________________ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
