Martin Kosek wrote:
On Wed, 2011-09-14 at 16:39 -0400, Rob Crittenden wrote:
Suppress managed netgroups as indirect members of hosts. This enhances a
previous patch that I did for hostgroups.
rob
This works fine. I just one suggestion for the code - the function
suppress_netgroup_memberof() function was already implemented in the
last patch:
https://fedorahosted.org/freeipa/changeset/ca1ca17cb61516dff6933b1b0381b32e1e38d44c
for hostgroup. I suggest making this function more general and calling
it from both host and hostgroup objects.
Martin
I looked at that. For the hostgroup once you find your own entry you can
exit, for hosts you have to look at all netgroups. The dn comparison is
also very different. These could be handled as arguments but I think the
code would be less clear so I chose quasi-duplication.
rob
_______________________________________________
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel
