O.K. the subject is a bit deceptive, there is no patch, this is really a
review request and I'm going to handle this a bit differently. Rather
than attaching a patch I'm including a link to the module's HTML
documentation. You'll be able to read the documentation and follow links
which may be a better introduction for a review. Don't worry, the actual
source is there too! Every page has a clickable link "Source Code".
Here is the doc (and source):
http://jdennis.fedorapeople.org/log_manager_doc/
By the way, this is the proposed fix for ticket 2022
(https://fedorahosted.org/freeipa/ticket/2022). Which grew out of my
frustration with not being able to turn on debug logging when running
the unit tests. This should solve that problem, consolidate a lot of
existing duplicated code spread out across our code base and make using
logging easier and more productive, especially for developers.
Just one minor caveat. The module needs to be located in ipapython
because it will be used by all our code. At the moment there is a
IPALogManger class which is subclassed from the generic LogManager
class. This is mostly for reading the logging config from our Env
configuration and enforcing some IPA standards. But Env is located in
ipalib.config so we may want to move the IPALogManager class out of
ipapython and into ipalib (not entirely sure about that yet).
Comments and questions welcome of course.
P.S. there is a fair amount of doc with the rationale for why things
were done this way, plenty of examples and even a FAQ.
--
John Dennis <jden...@redhat.com>
Looking to carve out IT costs?
www.redhat.com/carveoutcosts/
_______________________________________________
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel
