On Fri, 2012-03-02 at 09:48 -0500, Rob Crittenden wrote: > Martin Kosek wrote: > > On Fri, 2012-03-02 at 08:46 -0500, Rob Crittenden wrote: > >> Martin Kosek wrote: > >>> On Thu, 2012-03-01 at 16:26 -0500, Rob Crittenden wrote: > >>>> Martin Kosek wrote: > >>>>> On Wed, 2012-02-29 at 11:20 +0100, Petr Viktorin wrote: > >>>>>> On 02/27/2012 06:31 PM, Martin Kosek wrote: > >>>>>>> > >>>>>>> 4) Minor change: > >>>>>>> - except Exception: > >>>>>>> + except: > >>>>>>> > >>>>>> > >>>>>> Don't do that. It would for example disable Ctrl+C by trapping > >>>>>> KeyboardInterrupt. > >>>>>> > >>>>>> PEP8 has a paragraph on this, search for 'except Exception:' > >>>>>> > >>>>>> > >>>>> > >>>>> Good to know, thanks. Rob, in that case please ignore issue #4. > >>>>> > >>>>> Martin > >>>> > >>>> Updated patch attached. > >>>> > >>>> rob > >>> > >>> This does not look like the right patch. > >>> > >>> Martin > >>> > >> > >> Right, it was just the new changes. All squashed together now. > >> > >> rob > > > > The new changes are ok, dates and default values are fine. > > > > But it seems like you squashed it with a wrong patch, its again raising > > an error when any master is not reachable (you can just interdiff 956-2 > > and 956-3 to see these malicious changes). > > > > Martin > > > > Added back and added another try/except block around connect to catch > those as well. > > rob
ACK. Pushed to master, ipa-2-2. Martin _______________________________________________ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
