On 04/09/2012 08:54 PM, Rob Crittenden wrote:
Password history wasn't working because the qsort comparison function
was comparing pointers, not data. This resulted in a random element
being removed from the history on overflow rather than the oldest.
We sort in reverse so we don't have to move elements inside the list
when removing to make more room. We just pop off the top then shove on
the new password. The history includes a time to make comparisons
straightforward (and LDAP doesn't guarantee order).
I've attached a test script to exercise things. I don't see a way to
easily include this into our current framework at the moment. We'd
need a way to switch users in the middle of a test.
the current QE CLI test already has test case for it. No worried.
Thanks for the fix.
Yi
rob
_______________________________________________
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel
--
yi zhang
qa @ mountain view office, 8th floor
cell: 408-509-6375
_______________________________________________
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel
