On Fri, 2012-05-18 at 16:41 +0200, Petr Viktorin wrote: > On 05/18/2012 04:24 PM, Martin Kosek wrote: > > On Fri, 2012-05-18 at 10:03 -0400, Rob Crittenden wrote: > >> Petr Viktorin wrote: > >>> The pwpolicy-find command had a bad condition that made IPA convert > >>> lifetime values for output only if those values were *not* being > >>> retrieved. > >>> With this patch, the conversion routine is called unconditionally (it > >>> has its own check for presence of the attributes). > >>> > >>> https://fedorahosted.org/freeipa/ticket/2726 > >>> > >>> Also, have the sorting code use a key function instead of a cmp; this is > >>> a Python best practice. > >>> Improve a comment -- policies with higher priority are and always were > >>> at the *end* of the list, not the beginning. (I'm not sure if we want it > >>> this way?) > >>> > >>> Regression test included. > >> > >> I haven't checked this in detail yet but the comment about priority may > >> be wrong. The priority is such that the lower the number the higher the > >> priority. I think that is what it meant. > >> > >> rob > >> > > > > Yup, the comment was right. Lower numbers, i.e. password policies with > > higher priority, were sorted in the top. > > > > Martin > > > > Ah, I see. Made it clear so the next person is not confused. >
It is OK now. The solution with key instead of cmp is indeed more readable. ACK. Pushed to master. Martin _______________________________________________ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel