Hello, this patch fixes ispersistent() call in LDAP driver interface.
We were lucky, because ISC_R_NOTIMPLEMENTED is evaluated as ISC_TRUE every time, but I want to be sure.
Petr^2 Spacek
From bfa32f2fa7d880a5c137cf1705202e939f1928e5 Mon Sep 17 00:00:00 2001 From: Petr Spacek <[email protected]> Date: Fri, 27 Jul 2012 14:58:22 +0200 Subject: [PATCH] Fix and comment ispersistent() call in LDAP driver interface. Signed-off-by: Petr Spacek <[email protected]> --- src/ldap_driver.c | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/src/ldap_driver.c b/src/ldap_driver.c index 51d618c5a2395c58b362a047096b1cf1fc40fbfd..470b6f315f0f4483eb60703b369891892368548a 100644 --- a/src/ldap_driver.c +++ b/src/ldap_driver.c @@ -309,6 +309,11 @@ free_ldapdb(ldapdb_t *ldapdb) isc_mem_putanddetach(&ldapdb->common.mctx, ldapdb, sizeof(*ldapdb)); } + +/** + * This method should never be called, because LDAP DB is "persistent". + * See ispersistent() function. + */ static isc_result_t beginload(dns_db_t *db, dns_addrdatasetfunc_t *addp, dns_dbload_t **dbloadp) { @@ -323,6 +328,10 @@ beginload(dns_db_t *db, dns_addrdatasetfunc_t *addp, dns_dbload_t **dbloadp) return ISC_R_SUCCESS; } +/** + * This method should never be called, because LDAP DB is "persistent". + * See ispersistent() function. + */ static isc_result_t endload(dns_db_t *db, dns_dbload_t **dbloadp) { @@ -1114,12 +1123,16 @@ nodecount(dns_db_t *db) return ISC_R_NOTIMPLEMENTED; } +/** + * Return TRUE, because database does not need to be loaded from disk + * or written to disk. + */ static isc_boolean_t ispersistent(dns_db_t *db) { UNUSED(db); - return ISC_R_NOTIMPLEMENTED; + return ISC_TRUE; } static void -- 1.7.11.2
_______________________________________________ Freeipa-devel mailing list [email protected] https://www.redhat.com/mailman/listinfo/freeipa-devel
