On 08/10/2012 05:45 PM, Rob Crittenden wrote:
Robert Crittenden wrote:
This looks good, I just want to amend the commit with the tickets that this
addresses before pushing.
It seems that this covers 1670-1674. Is 1392 included as well?
rob
----- Original Message -----
From: "John Dennis" <[email protected]>
To: "freeipa-devel" <[email protected]>
Sent: Friday, August 10, 2012 1:11:23 PM
Subject: [Freeipa-devel] [PATCH 76] Use DN objects instead of strings
Due to the size and disruptive nature of this patch it was reviewed and
tested outside the normal patch review process, see the thread "DN patch
and documentation" as well as other threads on this list. This patch is
the cumulative result of that review process.
John
Posting this since I haven't pushed the patch yet. I found this
installing with --selfsign:
diff --git a/ipaserver/install/certs.py b/ipaserver/install/certs.py
index 1bbee35..eebaa48 100644
--- a/ipaserver/install/certs.py
+++ b/ipaserver/install/certs.py
@@ -1048,7 +1048,7 @@ class CertDB(object):
# Prepare a simple cert request
req_dict = dict(PASSWORD=self.gen_password(),
SUBJBASE=self.subject_base,
- CERTNAME=DN('CN', nickname))
+ CERTNAME=DN(('CN', nickname)))
req_template = ipautil.SHARE_DIR + reqcfg + ".template"
conf = ipautil.template_file(req_template, req_dict)
fd = open(reqcfg, "w+")
ACK, please apply this on top of the original patch before pushing
--
John Dennis <[email protected]>
Looking to carve out IT costs?
www.redhat.com/carveoutcosts/
_______________________________________________
Freeipa-devel mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/freeipa-devel
