On Tue, Aug 28, 2012 at 08:51:31AM +0200, Petr Spacek wrote: > On 08/22/2012 03:35 PM, Adam Tkac wrote: > >On Mon, Aug 13, 2012 at 03:15:52PM +0200, Petr Spacek wrote: > >>Hello, > >> > >>this patch improves connection management in bind-dyndb-ldap and closes > >>https://fedorahosted.org/bind-dyndb-ldap/ticket/68 . > >> > >>It should prevent all deadlocks on connection pool in future. > > > >Ack, just check my pedantic comments below, please. > > I partially disagree with one comment below. Amended patch is attached. >
... > Well, zone_dn and rdata checks are really redundant. First use of > ldap_inst is in ldap_inst->mctx, so check is AFAIK necessary. > > I left REQUIRE(ldap_inst != NULL); in attached patch, other REQUIREs were > deleted. You are right, sorry for false alarm. Ack. Regards, Adam -- Adam Tkac, Red Hat, Inc. _______________________________________________ Freeipa-devel mailing list [email protected] https://www.redhat.com/mailman/listinfo/freeipa-devel
