On Thu, 2012-09-06 at 14:00 +0200, Martin Kosek wrote:
> On 09/06/2012 01:35 PM, Petr Vobornik wrote:
> > On 09/06/2012 11:51 AM, Martin Kosek wrote:
> >> Loopback address, "localhost" and "localnets" ACIs are no longer
> >> an issue for bind-dyndb-ldap. Allow them in our validators.
> >>
> >
> > Martin's patch works and looks good - ACK.
> >
> >
> > Attaching patch for Web UI part.
>
> Web UI validator works fine too, ACK.
>
> Pushed both patches to master, ipa-3-0.
>
> Martin
I forgot to fix one DNS zone unit test.
Fixed (patch attached) and pushed as a one(two)-liner.
Martin
>From adeb23af6feb6bee8fe28644c8e16888bc98b7ea Mon Sep 17 00:00:00 2001
From: Martin Kosek <mko...@redhat.com>
Date: Fri, 7 Sep 2012 13:49:15 +0200
Subject: [PATCH] Update DNS zone allow-query validation test
localhost and localnets ACIs are now allowed. Update the respective
unit test.
---
tests/test_xmlrpc/test_dns_plugin.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/test_xmlrpc/test_dns_plugin.py b/tests/test_xmlrpc/test_dns_plugin.py
index e5c8a7c03c5faf88607576ff32a6a6866d8f8c4f..e8c0b241cc56261061de3cf4397ec097683f10a9 100644
--- a/tests/test_xmlrpc/test_dns_plugin.py
+++ b/tests/test_xmlrpc/test_dns_plugin.py
@@ -1038,9 +1038,9 @@ class test_dns(Declarative):
dict(
desc='Try to add invalid allow-query to zone %r' % dnszone1,
- command=('dnszone_mod', [dnszone1], {'idnsallowquery': u'localhost'}),
+ command=('dnszone_mod', [dnszone1], {'idnsallowquery': u'foo'}),
expected=errors.ValidationError(name='allow_query',
- error=u'ACL name "localhost" is not supported'),
+ error=u"failed to detect a valid IP address from u'foo'"),
),
dict(
--
1.7.11.4
_______________________________________________
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel
