I didn't know that was possible - will adjust & test, thank you! Lynn Root Associate Software Engineer Red Hat
----- Original Message ----- From: "Martin Kosek" <mko...@redhat.com> To: "Jan Cholasta" <jchol...@redhat.com> Cc: "Lynn Root" <lr...@redhat.com>, freeipa-devel@redhat.com Sent: Tuesday, October 30, 2012 9:08:33 AM Subject: Re: [Freeipa-devel] [PATCH] Switch %r specifiers to %s in Public errors On 10/30/2012 09:04 AM, Jan Cholasta wrote: > Hi, > > On 29.10.2012 19:54, Lynn Root wrote: >> Hi all! >> >> This switch drops the preceding 'u' from strings in public error messages. >> >> Ticket: https://fedorahosted.org/freeipa/ticket/3121 >> >> This patch also addresses the unfriendly 'u' from re-raising errors from the >> external call to netaddr.IPAddress by passing a bytestring to the function. >> >> Ticket: https://fedorahosted.org/freeipa/ticket/2588 >> >> >> My first patch (and freeipa dev list email) ever! Let me know where there's >> room to improve. >> >> Lynn Root >> Associate Software Engineer >> Red Hat >> > > I think it would be nice if you kept the quotes around the values, as that is > probably the reason "%r" was used in the first place - i.e. use "'%s'" instead > of plain "%s". +1 With current patch, I assume that a lot of unit tests will fail as they check exact error message wording. I'd recommend running the whole test suite with your second patch revision. There is a short walkthrough how to set it up: http://freeipa.org/page/Testing Martin _______________________________________________ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
