When adding a duplicate member to a group, an error message is issued,
informing the user that the entry is already a member of the group. This
message was missing in case of an external member.
Ticket: https://fedorahosted.org/freeipa/ticket/3254
--
Regards,
Ana Krivokapic
Associate Software Engineer
FreeIPA team
Red Hat Inc.
From 0523951025f208120b3cef191a5d0ea1aa4770ed Mon Sep 17 00:00:00 2001
From: Ana Krivokapic <akriv...@redhat.com>
Date: Thu, 10 Jan 2013 09:58:22 -0500
Subject: [PATCH] Add missing error message when adding duplicate external
member to group
When adding a duplicate member to a group, an error message is issued,
informing the user that the entry is already a member of the group.
This message was missing in case of an external member.
Ticket: https://fedorahosted.org/freeipa/ticket/3254
---
ipalib/plugins/group.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ipalib/plugins/group.py b/ipalib/plugins/group.py
index f86b134e61fc8c7518a64d25329babee3398c6ef..89667eeb76683c80a0963d1a3df84c8d67d07e07 100644
--- a/ipalib/plugins/group.py
+++ b/ipalib/plugins/group.py
@@ -399,7 +399,7 @@ class group_add_member(LDAPAddMember):
result = add_external_post_callback('member', 'group', 'ipaexternalmember',
ldap, completed, failed, dn, entry_attrs,
keys, options, external_callback_normalize=False)
- failed['member']['group'] = restore + failed_sids
+ failed['member']['group'] += restore + failed_sids
return result
api.register(group_add_member)
--
1.8.0.2
_______________________________________________
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel
