Petr Viktorin wrote:
On 02/06/2013 10:55 AM, Jan Cholasta wrote:
On 5.2.2013 15:45, Petr Viktorin wrote:
On 02/05/2013 01:38 PM, Jan Cholasta wrote:
On 4.2.2013 15:49, Petr Viktorin wrote:
[...]
I see one of the changes is using has_key instead of `in` for a
CIDict.
Given that dict.has_key() is deprecated, I think a better solution
would
be to add __contains__ to CIDict. Is there a reason against that?
I think a separate patch with this and other changes to make CIDict
more
like dict would be better.
OK, I'll make a patch.
[...]
Updated patches attached.
The changes look good but I can no longer apply the patches. Can you
please rebase them?
Sure.
ACK
I think dropping raw=True in patch 99.3 is going to break a check later
where we look at the managedby attribute. Without raw this will be
managedby_host.
rob
_______________________________________________
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel
