On 09/03/2013 03:14 PM, Ana Krivokapic wrote:
On 09/03/2013 08:25 AM, Martin Kosek wrote:
On 09/02/2013 06:21 PM, Tomas Babej wrote:
On 09/02/2013 06:07 PM, Petr Viktorin wrote:
On 08/29/2013 05:56 PM, Ana Krivokapic wrote:
Hello,
This patch addresses ticket https://fedorahosted.org/freeipa/ticket/3867.
Patch works well.
It's temping to restart the discussion about how to wrap text output from
installation tools. Wrapping at 60 characters because it looks better in the
code seems suboptimal.
Does anyone remember if we established some guideline last time this came up?
I'm not sure if I'm missing something, but do we need a guideline here?
I don't see any reason why not have best of the both worlds, using print as a
function we can wrap the text inside the parenthesis
with no effect on the output whatsoever. Or use print statement, but enclose
the text in parenthesis. Or use backslash.
Yes. But whatever we choose, we need to make sure that the resulting text is
wrapped the same to avoid inconsistent output.
IMO we should do our best to keep the text wrapped at 80 characters in new or
updated texts. So I would prefer to have Ana's patch refactored a bit, to
change wrapping of the resulting from 60 to 80 characters.
Martin
Text is wrapped at 80 characters in the updated patch.
Thanks, ACK, pushėd to:
master: 7959f3ee1e38ce10e2f32a51c3fa0f45f949f06f
ipa-3-3: 95d3d3d60b9e981bcd192ed11242d58873fd09bf
--
Petr³
_______________________________________________
Freeipa-devel mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/freeipa-devel
