On 10/02/2013 04:34 PM, Petr Viktorin wrote:
As I found out when installing on a misconfigured system, we use wrong
argument order for NSPRError in nsslib. This patch corrects the problem.
ACK
A nitpick:
$ git diff HEAD~1 | pep8 --diff
./ipapython/nsslib.py:145:14: E111 indentation is not a multiple of four
./ipapython/nsslib.py:148:21: E128 continuation line under-indented for
visual indent
You are a bigger fan of pep8, so it's up to you...
FWIW raising NSPRError might not be correct; the nss.error.NSPRError
docstring states:
> Raised internally, there should be no need to raise this exception
> from with a Python program using python-nss.
--
Petr Vobornik
_______________________________________________
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel