On 10/09/2013 04:11 PM, Petr Viktorin wrote: > On 09/16/2013 05:13 PM, Petr Viktorin wrote: >> Hello, >> The first patch allow concatenating LazyText objects using `+`. This >> means we can break up long docstrings into multiple parts. Translators >> can then work on each part separately, and the whole translation is not >> lost when a small part is changed or added. >> >> The second patch splits up the docstring for Host*. I chose Host because >> it was updated since last release, so translators would have >> to-retranslate the text. In the future, whenever a long docstring is >> changed it should be broken up like this. >> The patch also updates translations, and adds the broken-up texts for >> French and Ukraininan. You can test by viewing Host help in one of these >> languages -- only the new section should be untranslated. > > Rebased to current master. > > I've added a patch to update translations, please apply it before the other > two. It makes the functional changes a bit clearer. > > Test with: > $ LANG=fr_FR ipa help host > > > > _______________________________________________ > Freeipa-devel mailing list > Freeipa-devel@redhat.com > https://www.redhat.com/mailman/listinfo/freeipa-devel
Looks good to me. ACK. -- Regards, Ana Krivokapic Associate Software Engineer FreeIPA team Red Hat Inc.
_______________________________________________ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel