On 02/26/2014 12:40 PM, Alexander Bokovoy wrote: > On Wed, 26 Feb 2014, Martin Kosek wrote: >> On 02/25/2014 07:15 PM, Alexander Bokovoy wrote: >>> On Tue, 25 Feb 2014, Tomas Babej wrote: >>>> Hi, >>>> >>>> As a part of a better cleanup procedure in the integration tests, >>>> make sure that winbindd is not running after uninstalling the IPA >>>> server. >>> Better patch 0140 attached. We simply need to stop and disable winbind in >>> adtrustinstance.uninstall() >> >> Looks good to me (and a better approach than Tomas' 155 it seems). Since you >> are touching this section anyway, can you please also replace bare except >> with >> "except Exception:"? >> >> It will allow admin to CTRL+C the stopping process when needed. > Sure, new patch is attached. There are two potentially long external > processes executed in the uninstall() so I changed to 'except > Exception:' in both. >
This is fine - ACK. I just removed the note about superseded Tomas' patch from your commit log, we do not need that note from git log history perspective. Pushed to master: e99fa380af7f257a319cbe6f8867bf258ab04e41 Martin _______________________________________________ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
