On 06/10/2014 07:11 PM, Petr Vobornik wrote: > On 10.6.2014 17:29, Nathaniel McCallum wrote: >> On Tue, 2014-06-10 at 16:45 +0200, Jan Cholasta wrote: >>> Hi, >>> >>> On 6.6.2014 20:33, Nathaniel McCallum wrote: >>>> I kept seeing the old plugin registration style when writing/reviewing >>>> code and I decided to fix it. Attached are patches to update the >>>> remaining 31 plugins from the old plugin registration style to the new >>>> style. >>>> >>>> This would be a great starting point for someone new to doing reviews. >>>> >>>> Nathaniel >>> >>> I can't imagine a situation in which having these in separate commits >>> would be beneficial, so I don't think this really deserves to be split >>> among multiple patches. >> >> My thought was to make it easier to review in small chunks for new >> reviewers. But if we want to do it as a single patch, one is attached. >> >> Nathaniel >> > > ACK > > btw it was easier to review the batch at once. > > should we also update the tutorial in ipalib/__init__.py and other comments? > > Note that there is quite a lot of `api.register(cls)` calls outside of > ipalib/plugins dir. IMHO it's OK since it's not a subject of this patch.
Pushed to master: 255cbb49763ff579feed935a5a725fc2b272749c Martin _______________________________________________ Freeipa-devel mailing list [email protected] https://www.redhat.com/mailman/listinfo/freeipa-devel
