On 06/30/2014 03:16 PM, Alexander Bokovoy wrote:
> On Mon, 30 Jun 2014, Martin Basti wrote:
>>> >We can use 'label = label.encode("ascii")' to detect if IDNA is needed,
>>> >without idna.ToASCII() conversion, and then use:
>>> >
>>> >is_nonnorm = any(encodings.idna.nameprep(x) != x for x in labels)
>>> Sounds good but don't forget exceptions' handling. :)
>>>
>>
>> Updated patch attached.
>>
>> I modified error messages, IDNA mapping is not only mapping to lowercase
> Looks good to me.ipa-adtrust-install, ipa dnsrecord-add validation worked as expected. I just had to add link to ticket https://fedorahosted.org/freeipa/ticket/4382 to the description. ACK. Pushed to master. Martin _______________________________________________ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
