On 07/02/2014 08:52 AM, Martin Kosek wrote:
On 07/02/2014 07:11 AM, Fraser Tweedale wrote:
On Mon, Jun 30, 2014 at 10:54:28AM +0200, Petr Vobornik wrote:
On 30.6.2014 09:13, Fraser Tweedale wrote:
On Fri, Jun 27, 2014 at 02:11:47PM +0200, Petr Vobornik wrote:
Make the label of these buttons consistent with other buttons which have
capital first letters.
--
Petr Vobornik
From 7214242fb0c5accc45b6af476a8ff7e7b1a7883f Mon Sep 17 00:00:00 2001
From: Petr Vobornik <pvobo...@redhat.com>
Date: Fri, 27 Jun 2014 13:59:11 +0200
Subject: [PATCH] webui: capitalize labels of undo and undo all buttons
Make the label of these buttons consistent with other buttons which have
capital first letters.
---
install/ui/test/data/ipa_init.json | 4 ++--
ipalib/plugins/internal.py | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/install/ui/test/data/ipa_init.json
b/install/ui/test/data/ipa_init.json
index
0c32395ee7d68440aea0271359b0ac88fed86c42..20a462fff3b664d2320946765d1dac21ac2b1929
100644
--- a/install/ui/test/data/ipa_init.json
+++ b/install/ui/test/data/ipa_init.json
@@ -563,8 +563,8 @@
"next": "Next",
"page": "Page",
"prev": "Prev",
- "undo": "undo",
- "undo_all": "undo all",
+ "undo": "Undo",
+ "undo_all": "Undo All",
"validation": {
"error": "Text does not match field pattern",
"datetime": "Must be an UTC date/time value (e.g.,
\"2014-01-20 17:58:01Z\")",
diff --git a/ipalib/plugins/internal.py b/ipalib/plugins/internal.py
index
f9ae831dc665b1282ded798023856dacec480e3b..cda9fdc7ba5237bc5bcfddbce20f47abbc210a40
100644
--- a/ipalib/plugins/internal.py
+++ b/ipalib/plugins/internal.py
@@ -708,8 +708,8 @@ class i18n_messages(Command):
"next": _("Next"),
"page": _("Page"),
"prev": _("Prev"),
- "undo": _("undo"),
- "undo_all": _("undo all"),
+ "undo": _("Undo"),
+ "undo_all": _("Undo All"),
Does this affect translations? The msgid "undo all" is present in
the PO files.
Yes
Translations are lost as a result of this change, due to case
sensitive translation lookup by msgid. I guess our translation
workflow takes care of this - in which case, ACK.
Speaking of which, I couldn't find anything on the wiki about how we
do our translations (i.e., how or when stuff gets pulled into/out of
transifex, who's responsible for that part of the process). Would
be good to find out more about it :)
Petr Viktorin takes care of pulling the translations before the release.
However, I must admit we do not have a firm translation workflow defined yet,
we try not to mess with translations close to the release, but we do not
announce official string freeze.
Martin
Hi,
I'd rather delay pushing this until 4.0.1, as with all non-essential
changes.
Due to patches coming in late in the release cycle we can't release with
translations for all the new features. I guess that's acceptable, but we
don't need to break the string "Undo".
--
Petr³
_______________________________________________
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel
