On 23.7.2014 15:17, Petr Vobornik wrote:
Fixed:
1. IE doesn't support value 'initial' in CSS rule.
2. setting innerHTML='' also destroys content of child nodes in
LoginScreen in IE -> reattached buttons have no text.
Should go into 4.0 Milestone
Found an issue in the implementation, new version attached.
--
Petr Vobornik
From 4697a76a171e8a64a3c118be77e1e818e196eaca Mon Sep 17 00:00:00 2001
From: Petr Vobornik <pvobo...@redhat.com>
Date: Tue, 22 Jul 2014 14:15:11 +0200
Subject: [PATCH] webui: internet explorer fixes
Fixed:
1. IE doesn't support value 'initial' in CSS rule.
2. setting innerHTML='' also destroys content of child nodes in
LoginScreen in IE -> reattached buttons have no text.
---
install/ui/less/widgets.less | 2 +-
install/ui/src/freeipa/widgets/LoginScreen.js | 8 +++++++-
2 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/install/ui/less/widgets.less b/install/ui/less/widgets.less
index c21a163a1061514061463060195a1adfff619752..7876307f1cdf44bdd548a89f6f49a7d83adbc2d5 100644
--- a/install/ui/less/widgets.less
+++ b/install/ui/less/widgets.less
@@ -4,7 +4,7 @@
.global-activity-indicator {
- bottom: initial;
+ bottom: auto;
height: auto;
background-color: rgba(0, 0, 0, 0.3);
color: white;
diff --git a/install/ui/src/freeipa/widgets/LoginScreen.js b/install/ui/src/freeipa/widgets/LoginScreen.js
index 3e0986435bc80a82a626aa85c6f9fe1a73988b58..e7e1b029e890469874ba040e6d4142f50afcdd3a 100644
--- a/install/ui/src/freeipa/widgets/LoginScreen.js
+++ b/install/ui/src/freeipa/widgets/LoginScreen.js
@@ -231,7 +231,13 @@ define(['dojo/_base/declare',
refresh: function() {
if (this.buttons_node) {
- this.buttons_node.innerHTML = "";
+ // detach button nodes politely
+ // hard methods like `innerHTML=''` might have undesired
+ // consequences, e.g., removal of children's content in IE
+ var bn = this.buttons_node;
+ while (bn.firstChild) {
+ bn.removeChild(bn.firstChild);
+ }
}
if (this.view === 'reset') {
this.show_reset_view();
--
1.9.3
_______________________________________________
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel
