On 08/13/2014 05:34 PM, Petr Viktorin wrote: > On 08/13/2014 05:17 PM, thierry bordaz wrote: ... >>> Patch submission technicalities: >>> Please don't add the "Reviewed by" tag to the commit message, it's >>> added when pushing. The other tags are not used FreeIPA. (What's a >>> "Flag Day"?) >>> When you send more patches that depend on each other, either attach >>> them all to one e-mail, or explicitly say what each patch depends on. >>> >> That is correct I used a review template that was for 389-ds and I >> will change it. 'Flag Day' was part of 389-DS template, it was a >> flag to inform if the fix had a wide impact (things needing to be >> ported/recompile). >> I split ULC fix into several logical sub fixes and you are right >> they are all related even if for example 0002 does not depend on 0001. >> Do you want I resend patch 0003 with the statement it relies on 0001 >> (and with the correct commit message ?). > > These guidelines just make it easier for us to handle the large numbers of > patches that land on the list. Try to follow them next time you send a patch > (or revision), but there's no need to resubmit things just to comply. > We can change the message when pushing if the patch contents are acked.
+1. The page describing our submission rules are described on this page: http://www.freeipa.org/page/Contribute/Code and this sub-page: http://www.freeipa.org/page/Contribute/Patch_Format including a patch description example. HTH, Martin _______________________________________________ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
