On 9/19/2014 7:29 AM, Petr Vobornik wrote:
Hello,
attached patches implements Web UI part of ID Views. Backend is
currently on review as well - thread "[PATCHES 247-259] ID views -
management part".
https://fedorahosted.org/freeipa/ticket/4535
I expect that backed can change and that the UI might influence it as
well. Therefore no UI integration tests nor static data files are
included in this patchset. They will follow when backend is stable.
First 5 patches extends UI framework to support the main patch (#754).
== [PATCH] 749 webui: improve breadcrumb navigation ==
Fixes issue when:
- user navigates to a nested facet
- refreshes browser
- uses breadcrumb navigation to go to parent entity page which requires
a pkey. E.g. from automount keys to maps.
The old code relies on the facet, that user visited the parent facet
before and therefore the facet has pkey stored. It fails after the
browser reload.
Allows to specify a containing_facet. It allows breadcrumb navigation to
return to a different facet than the 'default'.
ACK.
== [PATCH] 750 webui: treat value as pkey in link widget ==
Current default mechanism of a link widget assumes that pkeys of a
current facet are pkeys for the link. It works for the only usage - in
password policy. It's rather inflexible since it can't be used if the
keys are in other attribute. This behavior is also bad in nested
entities - creates a link to itself which is pointless.
This patch changes the default behavior to assume that the supplied
value are the pkeys and that the last pkey is the value to display.
It also keeps the old method of overriding `other_pkeys` method so if
the last and only pkey is the actual value to display then the method
can tranform it into the pkeys which keeps compatibility with descendant
widgets (`host_dnsrecord_entity_link_widget`,
`dnsrecord_host_link_widget`).
ACK.
== [PATCH] 751 webui: do not show internal facet name to user ==
ACK.
== [PATCH] 752 webui: allow to skip link widget link validation ==
ACK.
== [PATCH] 753 webui: add simple link column suppor ==
Usual link columns are link with primary key of current entity.
This patch allows to create a link to arbitrary non-nested entity.
ACK.
== [PATCH] 754 webui: new ID views section ==
I'll test this separately. Does your patch #754-1 work with Tomas'
latest patches (#247-2 - 270)?
--
Endi S. Dewata
_______________________________________________
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel
