On Thu, 2014-09-25 at 13:45 +0200, thierry bordaz wrote: > On 09/19/2014 07:49 PM, Nathaniel McCallum wrote: > > > This is an optimization from patch 0062 (rescinded) which I think is > > worth keeping. There is no ticket for this. > > > > > > _______________________________________________ > > Freeipa-devel mailing list > > [email protected] > > https://www.redhat.com/mailman/listinfo/freeipa-devel > Hello, > > That is exact that slapi* are doing a intensive usage of the > of alloc/free. Using a stack allocated mods would reduce the > number of alloc/free but I afraid it will not have a > significant impact. For example further slapi_modify_internal > is doing tons of alloc/free. > > Also I think it is not possible to use stack allocated mods. > In fact mods will be modified by internal_mod (for example to > add 'modifytimestamp', 'modifiersname') and mods will be > reallocated. This could also occurs from plugins. > Finally if a modify retry occurs, the original mods are > freeed.
See ldap/servers/slapd/task.c. In this file, everything is stack allocated except for the value itself. _______________________________________________ Freeipa-devel mailing list [email protected] https://www.redhat.com/mailman/listinfo/freeipa-devel
