Dne 8.10.2014 v 12:36 David Kupka napsal(a):
On 10/08/2014 09:29 AM, Jan Cholasta wrote:
Hi,

Dne 8.10.2014 v 09:09 David Kupka napsal(a):
https://fedorahosted.org/freeipa/ticket/4569

In renew_ca_cert and cainstance.py, dogtag should already be stopped in
the places you modified, so why the change?

I didn't noticed that it is already stopped, fixed.

Also I don't think it's a good idea to backup CS.cfg when dogtag is
still running (in cainstance.py). If the file is being modified by
dogtag at the time it is backed up, the backup may be corrupted.

Fixed, thanks.

CAInstance.backup_config should be called only when Dogtag is stopped as well, you don't need to change it.


Honza



It would be better to stop and start dogtag only once in ipa-upgradeconfig, not every time there is a modification to CS.cfg.

--
Jan Cholasta

_______________________________________________
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Reply via email to