On 20.10.2014 22:07, Endi Sukma Dewata wrote:
On 10/20/2014 12:22 PM, Petr Vobornik wrote:
Fixes issues when dialog is not removed from `IPA.opened_dialogs`
registry when dialog.close() is called while the dialog is not shown,
i.e., while other dialog is shown. Without it, the dialog is could be
incorrectly displayed.
New dialog's property `opened` handles whether dialog is intended to be
opened.
How to test:
Add new host with IP address outside of managed reverse zones to get
error 4304.
Didn't have a chance to test it, but the code looks fine. ACK.
Perhaps the 'opened' property can be renamed to 'enabled' or something
like that to avoid confusions with 'is_shown'.
I've added ticket to commit message:
https://fedorahosted.org/freeipa/ticket/4656
Pushed to:
master: 41a7d0bf472b21018715eedf0b4c56ccbeace1f1
ipa-4-1: d3de9c0ca1844a99b1d54952f6b4355e8c8188f8
--
Petr Vobornik
_______________________________________________
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel
