On 10/21/2014 09:12 AM, Thorsten Scherf wrote:
Just realized that I sent the email without body. Mea culpa. Here we go:
Fix entry_attr case to make migrate-ds work again
Migration of a OpenLDAP based directory to FreeIPA with some objectclasses
removed failed because of --user-ignore-attribute didn't work. Fixed
that by
making LDAPEntry object entry_attry lowercased.
https://fedorahosted.org/freeipa/ticket/4620
On [Mon, 20.10.2014 11:57], Thorsten Scherf wrote:
I don't see a guarantee that attr_blacklist's items will always be
lowercase. Wouldn't lowercasing the blacklist be safer?
Something like:
attr_blacklist_set = {a.lower() for a in attr_blacklist}
...
if attr.lower() in attr_blacklist_set
A few lines down is the objectclass blacklist handling; I think it needs
similar treatment.
Looks like the code is duplicated in _pre_migrate_group; it would be
nice to pull it out into a function and call it from both places.
--
Petr³
_______________________________________________
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel
