On 29/10/14 14:34, David Kupka wrote:
On 10/24/2014 03:05 PM, David Kupka wrote:
On 10/24/2014 01:06 PM, David Kupka wrote:
On 10/24/2014 10:43 AM, Martin Basti wrote:
On 24/10/14 09:51, David Kupka wrote:
https://fedorahosted.org/freeipa/ticket/4585
NACK
1)
Why is there line with 'DS System User?' The comment should depend on
service.
+ args = [
+ paths.USERADD,
+ '-g', group,
+ '-c', 'DS System User',
+ '-d', homedir,
+ '-s', shell,
+ '-M', '-r', name,
+ ]
This was part of the original code and I didn't notice it. Nice catch,
thanks.
2)
code create_system_user is duplicated between base and redhat tasks
with
platform dependent changes.
IMO it would be better to have one method to create user, with keyword
arguments. And then platform dependent method which will call
method to
create user with appropriate arguments (or with default arguments)
You're right it was ugly.
_______________________________________________
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel
I shouldn't break SOLID principles.
_______________________________________________
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel
Using super is probably better that explicit naming of parent class.
Let user (developer) override UID/GID and hope that he knows why ...
NACK
2014-10-29T02:28:02Z DEBUG File
"/usr/lib/python2.7/site-packages/ipaserver/install/installutils.py",
line 642, in run_script
return_value = main_function()
File "/sbin/ipa-server-install", line 1143, in main
dsinstance.create_ds_user()
File
"/usr/lib/python2.7/site-packages/ipaserver/install/dsinstance.py", line
159, in create_ds_user
shell=paths.NOLOGIN,
File "/usr/lib/python2.7/site-packages/ipaplatform/redhat/tasks.py",
line 415, in create_system_user
homedir, shell, uid, gid, comment)
2014-10-29T02:28:02Z DEBUG The ipa-server-install command failed,
exception: TypeError: create_system_user() takes at most 8 arguments (9
given)
--
Martin Basti
_______________________________________________
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel
