Hi,

Dne 27.11.2014 v 14:20 Martin Basti napsal(a):
Ticket: https://fedorahosted.org/freeipa/ticket/4771
Patch attached.

I would prefer if you did something like this instead:

1) Add validate_idn_normalized function with the normalized IDN check to ipapython.dnsutil, have it raise ValueError if the check fails. (Also please get rid of the map() call for better readability.)

 2) Use validate_idn_normalized in DNSNameParam.

 3) Do the following in validate_zonemgr_str:

    validate_idn_normalized(zonemgr)
    try:
        zonemgr = DNSName(zonemgr)
    except dns.exception.DNSException as e:
        raise ValueError(e)

Honza

--
Jan Cholasta

_______________________________________________
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Reply via email to