Dne 13.1.2015 v 17:20 Petr Vobornik napsal(a):
On 01/13/2015 05:06 PM, Jan Cholasta wrote:
Dne 13.1.2015 v 16:47 Petr Vobornik napsal(a):
On 01/13/2015 11:54 AM, Jan Cholasta wrote:
Dne 13.1.2015 v 10:46 Petr Vobornik napsal(a):
On 01/12/2015 06:07 PM, Jan Cholasta wrote:
Hi,

the attached patch fixes
<https://fedorahosted.org/freeipa/ticket/4824>.

Honza


Is there a reason why `installutils.check_server_configuration() `
is called in `cert_restore_prepare`, ie., method which is not
really connected with it, and not in `run` as for DATA backup?

Full restore may be done when IPA is not installed, but
cert_restore_prepare crashes when IPA is not installed, the check
prevents that.

Anyway, see the attached patch for an alternative, possibly better
approach.


Works, but with full restore I got:

     ...
     Disabling all replication.
     Unable to get connection, skipping disabling agreements: Unable to
bind to LDAP server: [Errno 2] No such file or directory
     Stopping IPA services
     Restoring files
     ...

I wonder if it needs a better error message, it may be confusing for
users.

Can you open a ticket for this? I would rather not deal with this right
now in this patch...

opened: https://fedorahosted.org/freeipa/ticket/4838

ACK, I'll leave push and rebase order of backup patches up to you

Thanks, rebased and pushed to:
master: abcbe271d5e022ac805b448c85ebe4790bae7fb1
ipa-4-1: a98bc2381b7152c7076223e6bd36a1411fa850eb

--
Jan Cholasta

_______________________________________________
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Reply via email to