On 12.3.2015 16:23, Rob Crittenden wrote: > David Kupka wrote: >> On 03/06/2015 06:00 PM, Martin Basti wrote: >>> Upgrade plugins which modify LDAP data directly should not be executed >>> in --test mode. >>> >>> This patch is a workaround, to ensure update with --test option will not >>> modify any LDAP data. >>> >>> https://fedorahosted.org/freeipa/ticket/3448 >>> >>> Patch attached. >>> >>> >>> >> >> Ideally we want to fix all plugins to dry-run the upgrade not just skip >> when there is '--test' option but it is a good first step. >> Works for me, ACK. >> > > I agree that this breaks the spirit of --test and think it should be > fixed before committing.
Considering how often is the option is used ... I do not think that this requires 'proper' fix now. It was broken for *years* so this patch is a huge improvement and IMHO should be commited in current form. We can re-visit it later on, open a ticket :-) -- Petr^2 Spacek -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code