On 05/15/2015 11:37 AM, Petr Spacek wrote: > Hello, > > this patch set adds meta-database which is one of prerequisites for other > work. > > These changes should not be user-visible. You might compile the plugin with > CFLAGS="-DMETADB_DEBUG" and check contect of /tmp/metadb.db after BIND > shutdown. > > Please see > https://fedorahosted.org/bind-dyndb-ldap/ticket/151 > https://fedorahosted.org/bind-dyndb-ldap/wiki/Design/MetaDB > for further information and let me know if you can help you somehow. >
In Patch 351 Rename ldap_entry_create() to ldap_entry_parse(), you should rename the functions also in documentation: https://github.com/pspacek/bind-dyndb-ldap/blob/4fb7bd42609c2b6a4ffbdf6f3a1e58e00d84fa1e/src/ldap_entry.c#L111 https://github.com/pspacek/bind-dyndb-ldap/blob/4fb7bd42609c2b6a4ffbdf6f3a1e58e00d84fa1e/src/ldap_entry.h#L101 Other than that, it looks good. I did no functional testing... It compiled, functional testing done by others. ACK Regards, -- Tomas Hozza Software Engineer - EMEA ENG Developer Experience PGP: 1D9F3C2D Red Hat Inc. http://cz.redhat.com -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
