Hello, it came to my mind that domain level for topology plugin should actually be number 2, not 1.
We already used number 1 for incompatible changes in DNS tree and I believe that it is not a good idea to have two places which say 'version 1' but and actually mean two different things. (DNS tree version 1 + domain level 1) Patch is attached. -- Petr^2 Spacek
From 447ab9bac54e6857e8f2266a5b378ebfc1c7afe8 Mon Sep 17 00:00:00 2001 From: Petr Spacek <pspa...@redhat.com> Date: Tue, 26 May 2015 14:09:34 +0200 Subject: [PATCH] Bump domain level for topology plugin to 2. Level 1 already used for incompatible changes in DNS schema. --- daemons/ipa-slapi-plugins/topology/topology.h | 2 +- ipalib/constants.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/daemons/ipa-slapi-plugins/topology/topology.h b/daemons/ipa-slapi-plugins/topology/topology.h index 38c2823f50153c6b02a234608869617c92d1bdf2..9a3c7e46eb8211c1f7a57a1f15346a0ca6e6a4ac 100644 --- a/daemons/ipa-slapi-plugins/topology/topology.h +++ b/daemons/ipa-slapi-plugins/topology/topology.h @@ -10,7 +10,7 @@ #define PLUGIN_NAME "ipa-topology-plugin" #define PLUGIN_VENDOR "freeipa" -#define PLUGIN_VERSION "1.0" +#define PLUGIN_VERSION "2.0" #define IPA_TOPO_PLUGIN_SUBSYSTEM "ipa-topology-plugin" #define IPA_TOPO_PREOP_DESC "ipa-topology-preop-subplugin" diff --git a/ipalib/constants.py b/ipalib/constants.py index b99306eaec1d7bcbec4612a8aa4a599d02ac73e5..bdea1e86c6b77fc3e0123d43c9ca5b0acd7bdb73 100644 --- a/ipalib/constants.py +++ b/ipalib/constants.py @@ -226,4 +226,4 @@ IPA_ANCHOR_PREFIX = ':IPA:' SID_ANCHOR_PREFIX = ':SID:' MIN_DOMAIN_LEVEL = 0 -MAX_DOMAIN_LEVEL = 1 +MAX_DOMAIN_LEVEL = 2 -- 2.1.0
-- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
